Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3107: target csiNodeExpandSecret beta in 1.27 #3531

Merged
merged 1 commit into from
Feb 9, 2023
Merged

KEP-3107: target csiNodeExpandSecret beta in 1.27 #3531

merged 1 commit into from
Feb 9, 2023

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Sep 21, 2022 •
edited
Loading

Signed-off-by: Humble Chirammal hchiramm@redhat.com

  • One-line PR description:

kubernetes/kubernetes#115451

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Sep 21, 2022
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2022
@humblec
Copy link
Contributor Author

humblec commented Sep 21, 2022

/assign @xing-yang

@xing-yang
Copy link
Contributor

Please update the following:

  1. Update PRR yaml file to Beta:
    https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-storage/3107.yaml#L5

  2. e2e tests requirements
    For a KEP targeting Beta to be merged, e2e tests need to be merged and added to the test grid. Once tests are added, update the KEP with a link to the tests:
    https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3107-csi-nodeexpandsecret#e2e-tests

  3. The existing KEP only has the first section of PRR filled out. Please fill out the remaining sections which are required for Beta:
    https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3107-csi-nodeexpandsecret#production-readiness-review-questionnaire

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2022
@humblec
Copy link
Contributor Author

humblec commented Sep 22, 2022

@xing-yang I have added the PRR change and attempted template completion. ptal. .thanks !

@humblec humblec requested review from xing-yang and removed request for saad-ali September 26, 2022 12:04
@xing-yang
Copy link
Contributor

https://github.com/kubernetes/enhancements/pull/3531/files#r978671231
e2e tests need to be added before this KEP targeting Beta can be merged.

@wojtek-t
Copy link
Member

/assign @deads2k

For PRR (although still missing SIG approval)

@humblec humblec changed the title KEP-3107: target csiNodeExpandSecret beta in 1.26 KEP-3107: target csiNodeExpandSecret beta in 1.27 Jan 12, 2023
@humblec
Copy link
Contributor Author

humblec commented Jan 12, 2023

Cc @zhucan

@jpbetz
Copy link
Contributor

jpbetz commented Feb 4, 2023

/lgtm for PRR
/assign @deads2k

@humblec humblec force-pushed the node-expand-1.26 branch 2 times, most recently from 0b84e3e to 40db538 Compare February 8, 2023 12:56
@humblec
Copy link
Contributor Author

humblec commented Feb 8, 2023

@deads2k I have addressed the final comment . Can you please review/approve this ? Thanks !

humblec added a commit to humblec/kubernetes that referenced this pull request Feb 8, 2023
@humblec
promote CSINodeExpandSecret feature to Beta
732b6e3 
This commit flip the feature gate of `CSINodeExpandSecret` to Beta
and default ON.
Reference:
kubernetes/enhancements#3107
kubernetes/enhancements#3531

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec humblec mentioned this pull request Feb 8, 2023
Merged
@xing-yang
Copy link
Contributor

From SIG Storage, we are waiting for this e2e test PR to be merged and shown in the test-grid:

kubernetes/kubernetes#115451

@humblec
KEP-3107: target csiNodeExpandSecret beta in 1.27
14b80ca 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@deads2k
Copy link
Contributor

deads2k commented Feb 8, 2023

@deads2k I have addressed the final comment . Can you please review/approve this ? Thanks !

Thanks. The answer looks good. I'm not sure if a bot will require you to use the exact question format from the template, but that is minor.

PRR lgtm

/approve

@humblec
Copy link
Contributor Author

humblec commented Feb 8, 2023

Thanks @deads2k 👍

@xing-yang
Copy link
Contributor

The PR to add the e2e test to test-grid is merged: kubernetes/test-infra#28681
I'll merge the KEP.

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, humblec, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit d9267da into kubernetes:master Feb 9, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 9, 2023
@jpbetz jpbetz mentioned this pull request Dec 1, 2023
Merged
rayowang pushed a commit to rayowang/kubernetes that referenced this pull request Feb 9, 2024
@humblec
promote CSINodeExpandSecret feature to Beta
be9b1f2 
This commit flip the feature gate of `CSINodeExpandSecret` to Beta
and default ON.
Reference:
kubernetes/enhancements#3107
kubernetes/enhancements#3531

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@logicalhan logicalhan logicalhan left review comments

@xing-yang xing-yang xing-yang left review comments

@deads2k deads2k deads2k left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@msau42 msau42 msau42 left review comments

Assignees

@xing-yang xing-yang

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
8 participants
@humblec @xing-yang @wojtek-t @jpbetz @deads2k @k8s-ci-robot @logicalhan @msau42