-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Test Plan section with prerequisite section from latest template #3390
Conversation
vinaykul
commented
Jun 13, 2022
- One-line PR description: Catch-up KEP to latest template sections for Test Plan.
- Issue link: In-Place Update of Pod Resources #1287
- Other comments:
Hi @vinaykul. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @dchen1107 @derekwaynecarr |
/assign @parul5sahoo @Priyankasaggu11929 Please review |
/unassign @Priyankasaggu11929 @parul5sahoo 👋 @vinaykul, Me & Parul are not the right people to review the PR changes. We would require someone from the appropriate SIGs to review the changes. Thank you! |
Hello @derekwaynecarr, @dchen1107, we need help reviewing the changes here, by the Enhancements Freeze (June 23, 2022). Could you please take a look ^. Thank you so much! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, vinaykul The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vinaykul Could you update the toc? |
@vinaykul can you update this to pass the verify job? |
@derekwaynecarr fixed and verified locally. thanks, |
/ok-to-test |
/lgtm |