Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Test Plan section with prerequisite section from latest template #3390

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

vinaykul
Copy link
Member

  • One-line PR description: Catch-up KEP to latest template sections for Test Plan.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @vinaykul. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot requested a review from dchen1107 June 13, 2022 15:54
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 13, 2022
@vinaykul
Copy link
Member Author

/assign @dchen1107 @derekwaynecarr

@vinaykul
Copy link
Member Author

/assign @parul5sahoo @Priyankasaggu11929

Please review

@Priyankasaggu11929
Copy link
Member

/unassign @Priyankasaggu11929 @parul5sahoo

👋 @vinaykul, Me & Parul are not the right people to review the PR changes. We would require someone from the appropriate SIGs to review the changes. Thank you!

@Priyankasaggu11929
Copy link
Member

Hello @derekwaynecarr, @dchen1107, we need help reviewing the changes here, by the Enhancements Freeze (June 23, 2022). Could you please take a look ^. Thank you so much!

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, vinaykul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@mrunalp
Copy link
Contributor

mrunalp commented Jun 16, 2022

@vinaykul Could you update the toc?

@derekwaynecarr
Copy link
Member

@vinaykul can you update this to pass the verify job?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@vinaykul
Copy link
Member Author

@derekwaynecarr fixed and verified locally. thanks,

@dims
Copy link
Member

dims commented Jun 17, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2022
@mrunalp
Copy link
Contributor

mrunalp commented Jun 17, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit f2c3ba9 into kubernetes:master Jun 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 17, 2022
@vinaykul
Copy link
Member Author

Thanks @dims and @Mrunal - looks like we are good for enhancements freeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants