-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2133: add GA criteria #3379
Conversation
@@ -27,12 +28,13 @@ stage: beta | |||
# The most recent milestone for which work toward delivery of this KEP has been | |||
# done. This can be the current (upcoming) milestone, if it is being actively | |||
# worked on. | |||
latest-milestone: "v1.24" | |||
latest-milestone: "v1.25" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, PTAL
@@ -351,7 +351,8 @@ can be achieved using the exec plugin. | |||
|
|||
#### Beta -> GA Graduation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the implementation history in the end of this doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. PTAL
@@ -351,7 +351,8 @@ can be achieved using the exec plugin. | |||
|
|||
#### Beta -> GA Graduation | |||
|
|||
TBD | |||
* existed in beta for at least 1 minor release | |||
* e2e test using an external implementation (e.g. [GCR](https://github.com/kubernetes/cloud-provider-gcp/tree/master/cmd/auth-provider-gcp)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
criteria lgtm
/assign @deads2k |
Signed-off-by: ruiwen-zhao <ruiwen@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
PRR looks good /approve |
/assign @derekwaynecarr |
/assign @dchen1107 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, deads2k, ruiwen-zhao, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KEP-2133: add GA graduation criteria
Signed-off-by: ruiwen-zhao ruiwen@google.com