Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1488: Update gce-pd csi migration test plan #3351

Merged
merged 1 commit into from
Jun 14, 2022
Merged

KEP-1488: Update gce-pd csi migration test plan #3351

merged 1 commit into from
Jun 14, 2022

Conversation

mattcary
Copy link
Contributor

@mattcary mattcary commented Jun 7, 2022

/cc @Jiawei0227
/cc @msau42
/cc @leiyiz
/assign @rhockenbury

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jun 7, 2022
@mattcary mattcary mentioned this pull request Jun 7, 2022
Closed
2 tasks
@leiyiz
Copy link

leiyiz commented Jun 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@rhockenbury
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@xing-yang
Copy link
Contributor

Looks good now.
@mattcary Please address the CI failure.

@mattcary
Copy link
Contributor Author

Done

@msau42 I fixed the test by putting you as the reviewer :-/

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@xing-yang
Copy link
Contributor

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 141d410 into kubernetes:master Jun 14, 2022
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

@leiyiz leiyiz Awaiting requested review from leiyiz

@msau42 msau42 Awaiting requested review from msau42

Assignees

@xing-yang xing-yang

@rhockenbury rhockenbury

@leiyiz leiyiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@mattcary @leiyiz @rhockenbury @xing-yang @k8s-ci-robot