-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update In-place Pod Vertical Scaling target to 1.25. Merge CRI KEP 2273 with 1287 #3292
Conversation
vinaykul
commented
May 3, 2022
- One-line PR description: Update In-place Pod Vertical Scaling alpha release target to 1.25. Merge KEP 2273 with 1278.
- Issue link: In-Place Update of Pod Resources #1287
- Other comments: Merged CRI KEP with main In-Place Pod Vertical Scaling KEP as per sig-node discussion on 04/26/2022
Hi @vinaykul. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @derekwaynecarr @dchen1107 @thockin @Random-Liu |
/ok-to-test |
/lgtm Thanks for merging two related KEPs into one. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, vinaykul The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// Resource configuration specific to Linux container. | ||
LinuxContainerResources linux = 2; | ||
// Resource configuration for the container. | ||
ContainerResources resources = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is how it was done..