Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-365: Pagination kep format #3283

Merged
merged 2 commits into from
Apr 29, 2022
Merged

KEP-365: Pagination kep format #3283

merged 2 commits into from
Apr 29, 2022

Conversation

wojtek-t
Copy link
Member

Ref #365

As discussed yesterday, just extracted the non-controversial part to a separate PR for now

/assign @deads2k @lavalamp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 21, 2022
@k8s-ci-robot k8s-ci-robot requested a review from apelisse April 21, 2022 11:51
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Apr 21, 2022
@k8s-ci-robot k8s-ci-robot requested a review from deads2k April 21, 2022 11:51
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 21, 2022
lavalamp
lavalamp reviewed Apr 21, 2022
View reviewed changes
keps/sig-api-machinery/365-paginated-lists/README.MD Outdated
## Terminology
### Goals

- Expose API chunking mechanism as opt-in for clients
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List API

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lavalamp
Copy link
Member

/approve

@deads2k I'll let you lgtm?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2022
@kikisdeliveryservice kikisdeliveryservice changed the title Pagination kep format KEP-365: Pagination kep format Apr 21, 2022
@wojtek-t wojtek-t force-pushed the pagination_kep_format branch from abbe2a0 to 09da809 Compare April 21, 2022 19:00
@deads2k
Copy link
Contributor

deads2k commented Apr 29, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8c1a7ac into kubernetes:master Apr 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@apelisse apelisse Awaiting requested review from apelisse

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@lavalamp lavalamp

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtek-t @lavalamp @k8s-ci-robot @deads2k