Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2091: Update Release Signoff Checklist #3212

Merged
merged 1 commit into from
Feb 4, 2022
Merged

KEP-2091: Update Release Signoff Checklist #3212

merged 1 commit into from
Feb 4, 2022

Conversation

astoycos
Copy link
Contributor

@astoycos astoycos commented Feb 4, 2022

  • One-line PR description: Kep incorrectly merged without updating of release signoff Checklist, resulted in the KEP being incorrectly booted from 1.24.
  • Other comments: This was a naive mistake, sorry about that!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2022
@k8s-ci-robot k8s-ci-robot requested review from dcbw and thockin February 4, 2022 17:00
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels Feb 4, 2022
@astoycos
Copy link
Contributor Author

astoycos commented Feb 4, 2022

/assign @thockin

@astoycos
Fillout Release Signoff Checklist update kep.yaml
1eb3baf 
Kep merged without updating of release signoff Checklist,
update this and the kep.yaml.

Signed-off-by: astoycos <astoycos@redhat.com>
@thockin
Copy link
Member

thockin commented Feb 4, 2022

kep.yaml neds to change status to "implementable"

@astoycos astoycos force-pushed the fix-implementable-status branch from 421f610 to 1eb3baf Compare February 4, 2022 17:28
thockin
thockin reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 18b4a6f into kubernetes:master Feb 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
3 participants
@astoycos @thockin @k8s-ci-robot