KEP-853: Improvement: Add periodSeconds field and fixed typo.

[Shubham82]

This PR Added the periodSecond field under policies section which we have to mention otherwise it gives the below error on applying hpa.yaml:

error: error validating "hpa.yaml": error validating data: ValidationError(HorizontalPodAutoscaler.spec.behavior.scaleUp.policies[0]): missing required field "periodSeconds" in io.k8s.api.autoscaling.v2beta2.HPAScalingPolicy; if you choose to ignore these errors, turn validation off with --validate=false

And also removed the % sign from the value, it is of int32 not string type. it gives the below error:

error: error validating "hpa.yaml": error validating data: [ValidationError(HorizontalPodAutoscaler.spec.behavior.scaleUp.policies[0].value): invalid type for io.k8s.api.autoscaling.v2beta2.HPAScalingPolicy.value: got "string", expected "integer"

It is useful for the Users.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Shubham (8e77406)

[k8s-ci-robot]

Welcome @Shubham82!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Shubham82. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Shubham82]

Hi @gjtempleton @mwielgus
Could please take a look!

thanks.

[kikisdeliveryservice]

Can you clarify: are you updating the kep to reflect the current behavior? Or suggesting a bug that needs to be fixed?

As a note this enhancement is currently implemented: https://github.com/kubernetes/enhancements/blob/master/keps/sig-autoscaling/853-configurable-hpa-scale-velocity/kep.yaml

[Shubham82]

Thanks, @kikisdeliveryservice for looking at this!

It is an update in the document. So any user who references this document gets the correct information.

[Shubham82]

/easycla

[Shubham82]

Hi @gjtempleton @mwielgus @kikisdeliveryservice

Friendly reminder for the review!

Thanks!

[mwielgus]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, Shubham82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/sig-autoscaling/OWNERS [mwielgus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment