KEP-2086: updates for v1.24 #3199
Conversation
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
…holing traffic Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
kind/kep
| @@ -167,6 +167,10 @@ Beta: | |||
| * feature gate `ServiceInternalTrafficPolicy` is enabled by default. | |||
| * consensus on how internalTrafficPolicy overlaps with topology-aware routing. | |||
|
|
|||
| GA: | |||
There was a problem hiding this comment.
Adding GA criteria now so we know what to work towards in v1.24 but keeping GA milestone in kep.yaml to v1.25
|
/assign @MaxRenaud @thockin |
| @@ -23,13 +23,13 @@ stage: beta | |||
| # The most recent milestone for which work toward delivery of this KEP has been | |||
| # done. This can be the current (upcoming) milestone, if it is being actively | |||
| # worked on. | |||
| latest-milestone: "v1.22" | |||
| latest-milestone: "v1.24" | |||
There was a problem hiding this comment.
You need to change the stage to stable and that will force you to make a PRR review.
There was a problem hiding this comment.
Kept it beta on purpose since we're not intending to go stable in v1.24.
There was a problem hiding this comment.
But I'm happy to do the PRR review for GA now if you think the PRR is in good enough shape :)
| * A per-node "blackhole" metric will be added to kube-proxy which represent Services that are being intentionally dropped (internalTrafficPolicy=Local and no endpoints). | ||
|
|
||
| TODO: add metric name once it's decided | ||
| * A per-node "blackhole" metric will be added to kube-proxy which represent Services that are being intentionally dropped (internalTrafficPolicy=Local and no endpoints). The metric will be named `kubeproxy/sync_proxy_rules/blackhole_total` (subject to rename). |
There was a problem hiding this comment.
Do we want to qualify this with a label for internal/external?
For names, maybe "policy_local_no_endpoints" or something.
There was a problem hiding this comment.
Good call -- renamed to kubeproxy/sync_proxy_rules_no_endpoints_total, and added a note to add two labels for internal/external policy values.
k8s-ci-robot
added
the
approved
…no_endpoints_total Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding work towards GA in v1.24, but not planning to actually GA until v1.25