-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2712: Update Pod Priority Based Graceful Shutdown kep to target beta #3194
KEP-2712: Update Pod Priority Based Graceful Shutdown kep to target beta #3194
Conversation
00477d1
to
d7632cf
Compare
/lgtm |
/assign @deads2k |
/lgtm |
|
||
# The milestone at which this feature was, or is targeted to be, at each stage. | ||
milestone: | ||
alpha: "v1.23" | ||
beta: "v1.24" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This KEP appears to have gaps in the monitoring and troubleshooting sections. Please update with how to know this feature is working, how to know this feature is breaking at scale, and how debug this feature.
d7632cf
to
fad3062
Compare
Signed-off-by: Mrunal Patel <mpatel@redhat.com>
fad3062
to
ca1c1f3
Compare
PRR lgtm, Thanks for updating with a way to gain sufficient visibility to prove whether the feature is functional or not. I suggest working out the details of how to expose a useful metric to measure with sig-instrumentation (perhaps @ehashman ?), but I can now see how a cluster-admin could have confidence this feature is working. /approve |
This looks good to me. We should work out where and how the end time is stored on the host so it can be read on reboot during implementation. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, derekwaynecarr, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mrunal Patel mpatel@redhat.com
Update pod priority based graceful shutdown kep for beta