Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2712: Update Pod Priority Based Graceful Shutdown kep to target beta #3194

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Jan 27, 2022

Signed-off-by: Mrunal Patel mpatel@redhat.com

  • One-line PR description:
    Update pod priority based graceful shutdown kep for beta
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2022
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 27, 2022
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 27, 2022
@mrunalp mrunalp force-pushed the pod_priority_shutdown_beta branch from 00477d1 to d7632cf Compare January 27, 2022 23:04
@bobbypage
Copy link
Member

/lgtm
/cc @wzshiming

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2022
@ehashman
Copy link
Member

ehashman commented Feb 1, 2022

/assign @deads2k

@wzshiming
Copy link
Member

/lgtm


# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.23"
beta: "v1.24"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This KEP appears to have gaps in the monitoring and troubleshooting sections. Please update with how to know this feature is working, how to know this feature is breaking at scale, and how debug this feature.

@mrunalp mrunalp force-pushed the pod_priority_shutdown_beta branch from d7632cf to fad3062 Compare February 2, 2022 16:38
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2022
Signed-off-by: Mrunal Patel <mpatel@redhat.com>
@mrunalp mrunalp force-pushed the pod_priority_shutdown_beta branch from fad3062 to ca1c1f3 Compare February 2, 2022 20:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2022
@deads2k
Copy link
Contributor

deads2k commented Feb 2, 2022

PRR lgtm, Thanks for updating with a way to gain sufficient visibility to prove whether the feature is functional or not. I suggest working out the details of how to expose a useful metric to measure with sig-instrumentation (perhaps @ehashman ?), but I can now see how a cluster-admin could have confidence this feature is working.

/approve

@derekwaynecarr
Copy link
Member

This looks good to me.

We should work out where and how the end time is stored on the host so it can be read on reboot during implementation.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, derekwaynecarr, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit b26c25d into kubernetes:master Feb 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants