Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue from golangci-lint #3129

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

sanposhiho
Copy link
Member

This PR fixes an issue from golangci-lint.

(*'-') < make verify-golangci-lint

...

pkg/repo/repo.go:270:2: Consider preallocating `allKEPs` (prealloc)
        var allKEPs []*api.Proposal
        ^
make: *** [verify-golangci-lint] Error 1

And I think we can enable golangci-lint in prow-job. It's skipped currently.
https://github.com/kubernetes/enhancements/blob/master/hack/verify.sh#L40

/cc @justaugustus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/enhancements Issues or PRs related to the Enhancements subproject labels Jan 12, 2022
@mkimuram
Copy link
Contributor

@justaugustus I confirmed that make verify-golangci-lint causes the error and this PR fixs this issue. Can this PR be merged?

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5b83201 into kubernetes:master Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants