Skip to content

Graduate PreferNominatedNode to GA #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

Graduate PreferNominatedNode to GA #3057

merged 1 commit into from
Dec 9, 2021

Conversation

chendave
Copy link
Member

Signed-off-by: Dave Chen dave.chen@arm.com

  • One-line PR description:
    Move PreferNominatedNode to GA
  • Other comments:

@Huang-Wei @wojtek-t @ahg-g

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2021
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Nov 23, 2021
alculquicondor
alculquicondor reviewed Nov 23, 2021
View reviewed changes
keps/sig-scheduling/1923-prefer-nominated-node/README.md Outdated
@@ -198,6 +199,11 @@ in back-to-back releases.
- Gather feedback from developers and surveys.
- The feature is guarded by a feature flag, and will be enabled by default in beta.

#### GA

- No negtive feedback.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

negative

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

keps/sig-scheduling/1923-prefer-nominated-node/README.md
#### GA

- No negtive feedback.
- The feature gate `PreferNominatedNode` will graduate to GA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a link to the testgrid for integration and benchmark tests that you can include here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched in the testgrid (https://k8s-testgrid.appspot.com/sig-scheduling) and haven't found the link of the integration test.

Also the perf dash seems cannot tell much details about the individual metrics (https://perf-dash.k8s.io/#/?jobname=scheduler-perf-benchmark&metriccategoryname=Scheduler&metricname=BenchmarkResults&benchmark=BenchmarkPerfScheduling%2FSchedulingBasic%2F500Nodes-8&metricName=time)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://k8s-testgrid.appspot.com/presubmits-kubernetes-blocking#pull-kubernetes-integration

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for showing me the link, will update.

alculquicondor
alculquicondor reviewed Nov 25, 2021
View reviewed changes
keps/sig-scheduling/1923-prefer-nominated-node/README.md Outdated

- No negative feedback.
- The feature gate `PreferNominatedNode` will graduate to GA.
- [Integration test](https://k8s-testgrid.appspot.com/presubmits-kubernetes-blocking#pull-kubernetes-integration) is in place and updated, search `TestPreferNominatedNode` and check the status.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the query to the specific test(s)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alculquicondor
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2021
@Huang-Wei
Copy link
Member

LGTM.

@chendave
Copy link
Member Author

/assign @wojtek-t for PRR. thanks!

@chendave
Copy link
Member Author

/assign @wojtek-t

wojtek-t
wojtek-t reviewed Dec 9, 2021
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit - other than that LGTM.

keps/sig-scheduling/1923-prefer-nominated-node/kep.yaml Outdated
@@ -5,7 +5,7 @@ authors:
owning-sig: sig-scheduling
participating-sigs:
- sig-scheduling
status: implementable
status: implemented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change - we mark KEPs as implemented only after the release in which the features goes to stable is actually released (so in this case, only when 1.24 will be out).

@chendave
Graduate PreferNominatedNode to GA
cc12cd7 
Signed-off-by: Dave Chen <dave.chen@arm.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2021
@wojtek-t
Copy link
Member

wojtek-t commented Dec 9, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, chendave, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5042518 into kubernetes:master Dec 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

+1 more reviewer

@alculquicondor alculquicondor alculquicondor left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@alculquicondor alculquicondor

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
5 participants
@chendave @alculquicondor @Huang-Wei @wojtek-t @k8s-ci-robot