KEP-2906 and KEP-2985: move and update KRM fn schema #3024
Conversation
From KEP-2985 to KEP-2906
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
kind/kep
mengqiy
force-pushed
the
krmfnmetadataschema
branch
from
ec0faaa to
7ae6838
Compare
|
/cc @jeremyrickard |
| sha256: | ||
| description: The degist of the binary that can be used to verify the binary. | ||
| type: string | ||
| home: |
There was a problem hiding this comment.
Do we need this, usage and examples? Do you think they'll often point different places, and if so, why?
There was a problem hiding this comment.
IMO home is really optional, while usage and examples are required.
usage should be the man page for the function. A pointer to a markdown file should be good.
In kpt project, each function example is self-contained directory. It has some KRM resources as input, fn config and some configuration to test the example. We can ensure the examples always work. IMO we can do something similar here.
WDYT?
There was a problem hiding this comment.
Sounds reasonable. Let's start with this, and we can evolve it if needed.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The 1st commit is a pure move of the fn metadata schema.
The 2nd commit updates the schema and the places that reference it.