KEP-1040: Generalize shuffle sharding for req width and extra latency #2810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MikeSpreitzer
commented
Jul 6, 2021
MikeSpreitzer
commented
- One-line PR description: Updates the shuffle sharding technique in APF to account for general request width and extra latency.
- Issue link:
- Other comments:
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
wojtek-t
reviewed
Jul 7, 2021
| queue length. With the generalizations for width and extra latency, | ||
| the work in a queue is the sum of the work in its waiting requsts. | ||
| The work in a request is the product of its width and its total | ||
| estimated execution duration (including extra latency). |
There was a problem hiding this comment.
FTR - This is already mentioned in the KEP below too:
But I'm obviously not opposed to putting it here too.
|
/lgtm /assign @lavalamp |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.