Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 2000: Update graceful shutdown KEP for beta #2472

Merged
merged 1 commit into from
Feb 9, 2021
Merged

KEP 2000: Update graceful shutdown KEP for beta #2472

merged 1 commit into from
Feb 9, 2021

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Feb 8, 2021 •
edited
Loading

  • Target beta in 1.21
  • Add PRR review

Enhancement issue: #2000

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2021
@bobbypage
Copy link
Member Author

/cc @mrunalp

@bobbypage
Copy link
Member Author

/cc @johnbelamaric

@johnbelamaric
Copy link
Member

PRR looks good, I will approve it once the PR has SIG approval.

@mrunalp
Copy link
Contributor

mrunalp commented Feb 9, 2021

/approve

@johnbelamaric
Copy link
Member

Needs approval from a SIG Node lead

ehashman
ehashman reviewed Feb 9, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

keps/sig-node/2000-graceful-node-shutdown/kep.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@derekwaynecarr
Copy link
Member

/assign

@bobbypage
Update graceful shutdown KEP for beta
27f1a4e 
* Target beta in 1.21
* Add PRR review
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, derekwaynecarr, johnbelamaric, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit cd4cf82 into kubernetes:master Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 9, 2021
@bobbypage bobbypage mentioned this pull request Feb 9, 2021
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@ehashman ehashman

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
6 participants
@bobbypage @johnbelamaric @mrunalp @derekwaynecarr @k8s-ci-robot @ehashman