Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark graceful node shutdown KEP as implementable #2063

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Mark graceful node shutdown KEP as implementable #2063

merged 2 commits into from
Oct 2, 2020

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Oct 2, 2020 •
edited
Loading

  • Add alpha graduation criteria
  • Update implementation history

Addressing #2000 (comment)

@bobbypage
Mark graceful node shutdown KEP as implementable
e6828a6 
* Add alpha graduation criteria
* Update implementation history
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Oct 2, 2020
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 2, 2020
@bobbypage
Copy link
Member Author

/cc @kikisdeliveryservice

kikisdeliveryservice
kikisdeliveryservice reviewed Oct 2, 2020
View reviewed changes
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Thank you for the changes LGTM

@mrunalp
Copy link
Contributor

mrunalp commented Oct 2, 2020

👍

@bobbypage
Copy link
Member Author

/assign @dchen1107

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, dchen1107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit ae39895 into kubernetes:master Oct 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 2, 2020
@pacoxu pacoxu mentioned this pull request Oct 12, 2024
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 dchen1107 left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
5 participants
@bobbypage @mrunalp @dchen1107 @k8s-ci-robot @kikisdeliveryservice