-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Initial proposal for hierarchial namespace controller subproject #1686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please update the structure to follow the new process as defined in https://raw.githubusercontent.com/kubernetes/enhancements/master/keps/NNNN-kep-template/README.md |
@enj I think I covered it. Let me know if I missed something. Issue created here: #1687 |
I think you still need these steps (note that you can only see them in raw view of the file):
|
Done! |
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
@kubernetes/sig-auth-proposals |
Looks like github is having some issues, will retest when it recovers. |
/test pull-enhancements-verify |
@mikedanese let me know if anything else is needed from me for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to set some time aside to do an API review (possibly high bandwidth meeting) followed by a code review (possibly async).
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
@enj Is this needed before merging this PR? Since it is part of the graduation criteria, and the KEP is provisional I'd think it could be done out of band of this PR? |
One more question. Please squash commits. |
Squashed |
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
keps/sig-auth/1687-hierarchical-namespaces-subproject/README.md
Outdated
Show resolved
Hide resolved
Thanks. I'm happy with the graduation criteria. @enj please take a look. |
LGTM. Do we need to schedule something explicit to make sure we get to the intake requirements soon-ish? Since this is outside of |
@mikedanese mentioned to open GH issues to track this, but which repo should I open it in? The main sig-auth repo? |
I think that's the best place to start, yes. Thanks!
…On Sat, May 9, 2020 at 9:25 PM Ryan Bezdicek ***@***.***> wrote:
LGTM. Do we need to schedule something explicit to make sure we get to the
intake requirements soon-ish? Since this is outside of k/k, I believe we
are not bound by the v1.19 release schedule and thus it may make sense to
focus on other efforts that must be completed by enchantment freeze.
@mikedanese <https://github.com/mikedanese> mentioned to open GH issues
to track this, but which repo should I open it in? The main sig-auth repo?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1686 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE43PZAJ7J55MOMUSEDXVELRQX7ANANCNFSM4MIHQHQQ>
.
|
Hi all, I am wondering whether we (Release enhancements team) need to track this. This is all out-of-tree and not delivered with the k8s release, correct? |
@johnbelamaric yep that’s correct |
Thanks, then we won't track. |
Open issues in the multi tenancy repo for the various inclusion requirements and cc me. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese, rjbez17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A KEP for the submission of hierarchial namespace controller as a subproject of sig-auth. The filename and status represents a provisional draft until discussed at the sig-auth meeting on April 15th 2020.
cc: @adrianludwin @tashimi @srampal