Skip to content

Initial proposal for hierarchial namespace controller subproject #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020

Conversation

rjbez17
Copy link
Contributor

@rjbez17 rjbez17 commented Apr 15, 2020

A KEP for the submission of hierarchial namespace controller as a subproject of sig-auth. The filename and status represents a provisional draft until discussed at the sig-auth meeting on April 15th 2020.

cc: @adrianludwin @tashimi @srampal

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2020
@k8s-ci-robot k8s-ci-robot requested review from deads2k and enj April 15, 2020 03:33
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Apr 15, 2020
@enj
Copy link
Member

enj commented Apr 15, 2020

Please update the structure to follow the new process as defined in https://raw.githubusercontent.com/kubernetes/enhancements/master/keps/NNNN-kep-template/README.md

@rjbez17
Copy link
Contributor Author

rjbez17 commented Apr 15, 2020

Please update the structure to follow the new process as defined in https://raw.githubusercontent.com/kubernetes/enhancements/master/keps/NNNN-kep-template/README.md

@enj I think I covered it. Let me know if I missed something. Issue created here: #1687

@enj
Copy link
Member

enj commented Apr 15, 2020

I think you still need these steps (note that you can only see them in raw view of the file):

  • Make a copy of this template directory.
    Copy this template into the owning SIG's directory and name it NNNN-short-descriptive-title, where NNNN is the issue number (with no leading-zero padding) assigned to your enhancement above.
  • Fill out as much of the kep.yaml file as you can.
    At minimum, you should fill in the "title", "authors", "owning-sig", "status", and date-related fields.

@mikedanese mikedanese self-assigned this Apr 15, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2020
@rjbez17
Copy link
Contributor Author

rjbez17 commented Apr 16, 2020

I think you still need these steps (note that you can only see them in raw view of the file):

* [ ]  **Make a copy of this template directory.**
  Copy this template into the owning SIG's directory and name it `NNNN-short-descriptive-title`, where `NNNN` is the issue number (with no leading-zero padding) assigned to your enhancement above.

* [ ]  **Fill out as much of the kep.yaml file as you can.**
  At minimum, you should fill in the "title", "authors", "owning-sig", "status", and date-related fields.

Done!

@mikedanese
Copy link
Member

@kubernetes/sig-auth-proposals

@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label Apr 22, 2020
@rjbez17
Copy link
Contributor Author

rjbez17 commented Apr 23, 2020

Looks like github is having some issues, will retest when it recovers.

@rjbez17
Copy link
Contributor Author

rjbez17 commented Apr 23, 2020

/test pull-enhancements-verify

@rjbez17
Copy link
Contributor Author

rjbez17 commented Apr 28, 2020

@mikedanese let me know if anything else is needed from me for this PR.

Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to set some time aside to do an API review (possibly high bandwidth meeting) followed by a code review (possibly async).

@rjbez17
Copy link
Contributor Author

rjbez17 commented May 5, 2020

We probably need to set some time aside to do an API review (possibly high bandwidth meeting) followed by a code review (possibly async).

@enj Is this needed before merging this PR? Since it is part of the graduation criteria, and the KEP is provisional I'd think it could be done out of band of this PR?

@mikedanese
Copy link
Member

One more question. Please squash commits.

@rjbez17
Copy link
Contributor Author

rjbez17 commented May 9, 2020

One more question. Please squash commits.

Squashed

@mikedanese
Copy link
Member

Thanks. I'm happy with the graduation criteria. @enj please take a look.

@enj
Copy link
Member

enj commented May 9, 2020

LGTM. Do we need to schedule something explicit to make sure we get to the intake requirements soon-ish? Since this is outside of k/k, I believe we are not bound by the v1.19 release schedule and thus it may make sense to focus on other efforts that must be completed by enchantment freeze.

@rjbez17
Copy link
Contributor Author

rjbez17 commented May 10, 2020

LGTM. Do we need to schedule something explicit to make sure we get to the intake requirements soon-ish? Since this is outside of k/k, I believe we are not bound by the v1.19 release schedule and thus it may make sense to focus on other efforts that must be completed by enchantment freeze.

@mikedanese mentioned to open GH issues to track this, but which repo should I open it in? The main sig-auth repo?

@adrianludwin
Copy link

adrianludwin commented May 11, 2020 via email

@johnbelamaric
Copy link
Member

Hi all, I am wondering whether we (Release enhancements team) need to track this. This is all out-of-tree and not delivered with the k8s release, correct?

@rjbez17
Copy link
Contributor Author

rjbez17 commented May 13, 2020

Hi all, I am wondering whether we (Release enhancements team) need to track this. This is all out-of-tree and not delivered with the k8s release, correct?

@johnbelamaric yep that’s correct

@johnbelamaric
Copy link
Member

Thanks, then we won't track.

@mikedanese
Copy link
Member

mentioned to open GH issues to track this, but which repo should I open it in?

Open issues in the multi tenancy repo for the various inclusion requirements and cc me.

@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2020
@mikedanese
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 867dce3 into kubernetes:master May 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants