Prevent unauthorised volume mode conversion during volume restore

[RaunakShah]

Enhancement Description

• One-line enhancement description (can be used as a release note): Prevent unauthorised volume mode conversion during volume restore.

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3141-prevent-volume-mode-conversion

• Primary contact (assignee): @RaunakShah @xing-yang

• Responsible SIGs: SIG-Storage

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y): 1.24
  • Beta release target (x.y): 1.27
  • Stable release target (x.y): 1.30

• Alpha

  • KEP (k/enhancements) update PR(s):
    • https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3141-prevent-volume-mode-conversion
  • Code (k/k) update PR(s):
    • Update generated code for SourceVolumeMode field in VolumeSnapshotContents kubernetes-csi/external-snapshotter#665
    • Update snapshotter and client modules kubernetes-csi/external-snapshotter#670
  • Docs (k/website) update PR(s):
    • Add docs for preventing volume mode conversion website#32673

• Beta

  • KEP (k/enhancements) update PR(s):
    • KEP-3141: Graduate "Prevent unauthorised volume mode conversion" to Beta  #3556
  • Code (k/k) update PR(s):
    • Add tests for volume mode conversion feature kubernetes-csi/external-provisioner#867
    • Add and enable sidecar e2e test to enable volume mode conversion kubernetes-csi/external-provisioner#832
    • Fix string pointer comparison for source volume mode conversion kubernetes-csi/external-provisioner#793
    • Register metrics exposed by sig-storage-lib kubernetes-csi/external-provisioner#792
    • Change annotation name to allow volume mode change kubernetes-csi/external-provisioner#791
    • Add dataSource label to pvcs created kubernetes-sigs/sig-storage-lib-external-provisioner#128
    • Add optional canary job to all CSI sidecar repos test-infra#28307
  • Docs (k/website) update(s):
    • Update volume mode change annotation in documentation website#39367

• Stable

  • KEP (k/enhancements) update PR(s): KEP-3141: Graduate "Prevent unauthorised volume mode conversion" to Stable #4459, KEP-3141: Add no known failure modes to README #4497

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[RaunakShah]

/sig storage

[gracenng]

Hi @RaunakShah ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting alpha for 1.24, is that correct?.
Here’s where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for this release with latest-milestone: 1.24
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk
Thanks!

[xing-yang]

/milestone v1.24

[xing-yang]

@gracenng Yes, this is targeting Alpha in 1.24.

[gracenng]

Hi @RaunakShah , 1.24 Enhancements Team here.

Reaching out as we're less than a week away from Enhancement Freeze on Thursday, February 3rd.
Updated some points on the check list above, let me know if I missed anything.
I'm monitoring #3151 and current status is at risk

[gracenng]

All good for 1.24 Enhancements Freeze

[xing-yang]

@gracenng Should this have a Tracked/Yes label?

[didicodes]

Hi @xing-yang & @RaunakShah, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

[gracenng]

Hi @RaunakShah 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!