Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to the NetworkPolicy API for namespace.Name selection . #2112

Closed
jayunit100 opened this issue Oct 23, 2020 · 10 comments · Fixed by #2284
Closed

Add an option to the NetworkPolicy API for namespace.Name selection . #2112

jayunit100 opened this issue Oct 23, 2020 · 10 comments · Fixed by #2284
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@jayunit100
Copy link
Member

Enhancement Description

  • Add a namespace name selector field to the NetworkPolicy API
  • Kubernetes Enhancement Proposal:
  • Discussion Link: Network Policy NamespaceSelector Should All Match Against Name kubernetes#88253
  • Primary contact (assignee): jayunit100
  • Responsible SIGs: sig-network
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.21)
    • Beta release target (1.22)
    • Stable release target (1.23)
  • Documentation PR:
    • Alpha:
    • Beta:
    • Stable:
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 23, 2020
@jayunit100 jayunit100 changed the title Network policy namespace.Name selector Add a Network policy namespace.Name selector for more convenient namespace policy definitions Oct 23, 2020
@jayunit100 jayunit100 changed the title Add a Network policy namespace.Name selector for more convenient namespace policy definitions Add a NetworkPolicy namespace.Name selector for more convenient namespace policy definitions Oct 23, 2020
@jayunit100 jayunit100 changed the title Add a NetworkPolicy namespace.Name selector for more convenient namespace policy definitions Add a field to the NetworkPolicy API for namespace.Name selection option. Oct 23, 2020
@jayunit100
Copy link
Member Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 23, 2020
@jayunit100 jayunit100 mentioned this issue Oct 23, 2020
Closed
@jayunit100 jayunit100 changed the title Add a field to the NetworkPolicy API for namespace.Name selection option. Add an option to the NetworkPolicy API for namespace.Name selection . Oct 23, 2020
@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Oct 30, 2020
@jayunit100 jayunit100 mentioned this issue Jan 16, 2021
Merged
@jayunit100
Copy link
Member Author

update on this

@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 26, 2021
@annajung annajung added this to the v1.21 milestone Jan 26, 2021
@thockin
Copy link
Member

thockin commented Jan 26, 2021

Why do we need this AND #2161?

@annajung
Copy link
Contributor

Hi @jayunit100 👋 , 1.21 Enhancements Lead here.
I am also wondering how #2161 relates/differs from this issue. It looks like the PR you linked above makes changes to KEP related to #2161 and there is no KEP for #2112. Could you clarify so that we can track the correct enhancement?

@arunmk
Copy link

arunmk commented Feb 5, 2021

@jayunit100 I am one of the enhancement shadows for 1.21 and am reviewing this KEP.

I do not see a KEP for this. In the PR, there is a mention that this item is fixed by that PR. The kep there is also regarding 2161. Could you please clarify?

@jayunit100
Copy link
Member Author

jayunit100 commented Feb 5, 2021 •
edited
Loading

Hey ! This now moved to being an apimachinery KEP to add a default selector for namespace.name ! I'll update all this shortly

Thanks for pinging me !!!

@arunmk
Copy link

arunmk commented Feb 5, 2021

Thanks @jayunit100 . Could you please link the KEP when you update this issue.

@arunmk
Copy link

arunmk commented Feb 8, 2021

Hi @jayunit100,

(Based on the earlier conversation, there may not be a KEP here, but here is an update.)

Enhancements Freeze is 2 days away, Feb 9th EOD PST

We need a KEP for this issue.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

[MISSING] The KEP must be merged in an implementable state~
[MISSING] The KEP must have test plans~
[MISSING] The KEP must have graduation criteria~
[MISSING] The KEP must have a production readiness review

@thockin
Copy link
Member

thockin commented Feb 8, 2021

Do we need this issue, still? We have a KEP (#2162) which is different in scope but solves the problem.

@jayunit100
Copy link
Member Author

/close

@annajung annajung removed this from the v1.21 milestone Feb 9, 2021
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

apiserver default labels ~ Implementable jayunit100/enhancements
6 participants
@jayunit100 @thockin @kikisdeliveryservice @arunmk @k8s-ci-robot @annajung