Skip to content

Commit

Permalink
more clarifications
Browse files Browse the repository at this point in the history
  • Loading branch information
ahg-g committed Feb 6, 2023
1 parent df8d16a commit c6292b1
Showing 1 changed file with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ pod-to-node assignment to kube-scheduler.

In general, this opens the door for a new pattern of adding scheduling features to Kubernetes.
Specifically, building lightweight schedulers that implement features not supported by kube-scheduler,
while relying on the existing kube-scheduler to support all upstream featuers and handle the pod-to-node
while relying on the existing kube-scheduler to support all upstream features and handle the pod-to-node
binding. This pattern should be the preferred one if the custom feature doesn't require implementing a
scheduler plugin, which entails re-building and maintaining a custom kube-scheduler binary.

Expand All @@ -222,7 +222,7 @@ know that this has succeeded?
### Non-Goals

- Allow mutating node affinity/selector of pods unconditionally.
- Restrict updating tolerations on scheduling gates. We already allow adding tolerations
- Restrict adding tolerations on scheduling gates. We already allow adding tolerations
unconditionally, and so restricting that to gated pods is not a backward compatible change.
- Allow mutating pod (anti)affinity constraints. It is not clear how this can be done without
potentially violating a policy check that was previously done at pod CREATE.
Expand Down Expand Up @@ -282,6 +282,9 @@ Go in to as much detail as necessary here.
This might be a good place to talk about core concepts and how they relate.
-->

Note that constraining the node affinity/selector is a one way operation; meaning once done, it can't be
reserved and that a subsequent update can only further constraint the selection.

### Risks and Mitigations

- New calls from a queue controller to the API server to update node affinity/selector.
Expand Down Expand Up @@ -574,8 +577,8 @@ well as the [existing list] of feature gates.
-->

- [x] Feature gate (also fill in values in `kep.yaml`)
- Feature gate name: PodSchedulingReadiness
- Components depending on the feature gate:
- Feature gate name: PodSchedulingReadiness; note that this is a shared flag with the PodSchedulingReadiness feature.
- Components depending on the feature gate: kube-apiserver, kube-scheduler
- [ ] Other
- Describe the mechanism:
- Will enabling / disabling the feature require downtime of the control
Expand Down

0 comments on commit c6292b1

Please sign in to comment.