Skip to content

Commit

Permalink
add KEP4781
Browse files Browse the repository at this point in the history
  • Loading branch information
pololowww committed Aug 23, 2024
1 parent 4668a38 commit 8a625c4
Show file tree
Hide file tree
Showing 3 changed files with 600 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ newReplicaSetReplicas = replicasBeforeScale * \frac{deploymentMaxReplicas}{deplo
$$

This is currently done in the [getReplicaSetFraction](https://github.com/kubernetes/kubernetes/blob/1cfaa95cab0f69ecc62ad9923eec2ba15f01fc2a/pkg/controller/deployment/util/deployment_util.go#L492-L512)
function. The leftover pods are added to the newest ReplicaSet.
function. The leftover pods are added to the largest ReplicaSet (or newest if more than one ReplicaSet has the largest number of pods).

This results in the following scaling behavior.

Expand Down Expand Up @@ -364,7 +364,7 @@ As we can see, we will get a slightly different result when compared to the firs
due to the consecutive scales and the fact that the last scale is not yet fully completed.

The consecutive partial scaling behavior is a best effort. We still adhere to all deployment
constraints and have a bias toward scaling the newest ReplicaSet. To implement this properly we
constraints and have a bias toward scaling the largest ReplicaSet. To implement this properly we
would have to introduce a full scaling history, which is probably not worth the added complexity.

### kubectl Changes
Expand Down
Loading

0 comments on commit 8a625c4

Please sign in to comment.