Skip to content

Commit

Permalink
Address review comments 5
Browse files Browse the repository at this point in the history
  • Loading branch information
RomanBednar committed Jun 15, 2022
1 parent 6d49829 commit 7606e84
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions keps/sig-storage/3333-reconcile-default-storage-class/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,10 @@ ones.

- Feature implemented behind a feature flag.
- Initial integration tests completed and enabled.
- Implement and enable e2e tests, visible in Testgrid and linked in KEP.

#### Beta

- Implement and enable e2e tests, visible in Testgrid and linked in KEP.
- Scalability tests with existing framework ([perf-tests](https://github.com/kubernetes/perf-tests/tree/81c96c34e3c1f11c5fe91744ef7ce7bf44c2fe5c/clusterloader2/testing/experimental/storage/pod-startup/volume-types/persistentvolume)).
- Allowing time for feedback (at least 2 releases between beta and GA).
- No conformance tests, since we don't test StorageClasses there.
Expand All @@ -294,14 +294,6 @@ ones.

- No users complaining about the new behavior.

#### Deprecation

- Announce deprecation and support policy of the existing flag.
- Two versions passed since introducing the functionality that deprecates the
flag (to address version skew).
- Address feedback on usage/changed behavior, provided on GitHub issues.
- Deprecate the flag.

### Upgrade / Downgrade Strategy

No change in cluster upgrade / downgrade process.
Expand Down

0 comments on commit 7606e84

Please sign in to comment.