Skip to content

Commit

Permalink
[KEP-2568] Production Readiness Review.
Browse files Browse the repository at this point in the history
  • Loading branch information
vinayakankugoyal committed Apr 14, 2021
1 parent 07aaf97 commit 6be5b5c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
- [ ] (R) Design details are appropriately documented
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
- [ ] (R) Graduation criteria is in place
- [ ] (R) Production readiness review completed
- [x] (R) Graduation criteria is in place
- [x] (R) Production readiness review completed
- [ ] (R) Production readiness review approved
- [ ] "Implementation History" section is up-to-date for milestone
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
Expand Down Expand Up @@ -728,7 +728,7 @@ enhancement:

The flow below is assuming that the feature-flag to run control-plane as non-root is enabled.

`kubeadm` checks the cluster-config to see if the control-plane is already running as non-root. If so it re-writes the contents of the file and makes sure that the `UID`s and `GID`s previously assigned have permissions to read/write appropriately. The control-plane stati-pod manifests don't explicitly need to be updated for running them as non-root in this case.
`kubeadm` checks the cluster-config to see if the control-plane is already running as non-root. If so it re-writes the contents of the files/credentials and makes sure that the `UID`s and `GID`s previously assigned have permissions to read/write appropriately. The control-plane static-pod manifests don't explicitly need to be updated for running them as non-root in this case.

If the control-plane was not running as non-root before then `kubeadm` creates new `UID`s and `GID`s based on the approach mentioned in the [Assigning UID and GID](#assigning-uid-and-gid) section and updates the cluster-config. When files/credentials are re-written the owner of these files are set appropriately. The control-plane static-pod manifests explicitly need to be updated to run as non-root in this case.

Expand Down Expand Up @@ -1050,6 +1050,7 @@ Major milestones might include:
-->
Major milestones:
- Initial draft of KEP created - 2021-03-13
- Production readiness review - 2021-04-12

## Drawbacks

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ approvers:
- "@neolit123"
- "@fabriziopandini"
prr-approvers:
- TBD
- "@ehashman"

# The target maturity stage in the current dev cycle for this KEP.
stage: alpha
Expand Down

0 comments on commit 6be5b5c

Please sign in to comment.