Skip to content

Commit

Permalink
KEP-3107: update the test plan for nodeExpandSecret
Browse files Browse the repository at this point in the history
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
  • Loading branch information
humblec committed Jun 8, 2022
1 parent 8e7bf49 commit 4f4eddb
Showing 1 changed file with 29 additions and 7 deletions.
36 changes: 29 additions & 7 deletions keps/sig-storage/3107-csi-nodeexpandsecret/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
- [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional)
- [Risks and Mitigations](#risks-and-mitigations)
- [Design Details](#design-details)
- [Test Plan](#test-plan)
- [Graduation Criteria](#graduation-criteria)
- [Alpha](#alpha)
- [Beta](#beta)
Expand All @@ -25,6 +24,11 @@
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
- [Version Skew Strategy](#version-skew-strategy)
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
- [Test Plan](#test-plan)
- [Prerequisite testing updates](#prerequisite-testing-updates)
- [Unit tests](#unit-tests)
- [Integration tests](#integration-tests)
- [e2e tests](#e2e-tests)
- [Feature Enablement and Rollback](#feature-enablement-and-rollback)
- [Rollout, Upgrade and Rollback Planning](#rollout-upgrade-and-rollback-planning)
- [Monitoring Requirements](#monitoring-requirements)
Expand Down Expand Up @@ -139,12 +143,6 @@ message NodeExpandVolumeRequest {
The same field will be used by Kubernetes to fill secretRef in the
NodeExpandVolume request.

### Test Plan
- Unit tests around all the added logic in kubelet.
- Unit tests around all the added logic in kube-apiserver.
- E2E tests around nodeExpandVolume to make sure the field value has passed
and can be used.

### Graduation Criteria

#### Alpha
Expand All @@ -167,6 +165,30 @@ NodeExpandVolume request.

## Production Readiness Review Questionnaire

### Test Plan
[X] I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.

##### Prerequisite testing updates

No additional tests are needed.

##### Unit tests

- Unit tests around all the added logic in kubelet.

N/A

##### Integration tests

N/A

##### e2e tests

- E2E tests around nodeExpandVolume to make sure the field value has passed
and can be used.

### Feature Enablement and Rollback

- **How can this feature be enabled / disabled in a live cluster?**
Expand Down

0 comments on commit 4f4eddb

Please sign in to comment.