Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update distroless-iptables and base-debian11 images #575

Merged
merged 8 commits into from
Feb 13, 2023
Merged

Update distroless-iptables and base-debian11 images #575

merged 8 commits into from
Feb 13, 2023

Conversation

wewark
Copy link
Contributor

@wewark wewark commented Feb 10, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @wewark!

It looks like this is your first PR to kubernetes/dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @wewark. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2023
@wewark wewark changed the title Update distroless-iptables to v0.2.0-gke.2 Update distroless-iptables and base-debian11 Feb 13, 2023
@wewark wewark changed the title Update distroless-iptables and base-debian11 Update distroless-iptables and base-debian11 images Feb 13, 2023
@dpasiukevich
Copy link
Member

Fixes #572

@dpasiukevich
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 13, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@dpasiukevich
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@dpasiukevich
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@wewark
Copy link
Contributor Author

wewark commented Feb 13, 2023

/test pull-kubernetes-dns-test

@k8s-ci-robot
Copy link
Contributor

@wewark: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-kubernetes-dns-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dpasiukevich
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2023
@wewark
Copy link
Contributor Author

wewark commented Feb 13, 2023

/test pull-kubernetes-dns-test

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2023
@wewark
Copy link
Contributor Author

wewark commented Feb 13, 2023

/test pull-kubernetes-dns-test

dpasiukevich
dpasiukevich reviewed Feb 13, 2023
View reviewed changes
images/dnsmasq/validate_dynamic_deps.py Outdated
@@ -37,6 +38,9 @@ def detect_architecture(cwd: pathlib.Path, target_binary: pathlib.Path) -> str:
capture_output=True,
text=True,
cwd=cwd)
if len(result.stdout.split(",")) == 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< 2

and I'd suggest to move result.stdout.split(",") out to a var.

@dpasiukevich dpasiukevich mentioned this pull request Feb 13, 2023
Merged
dpasiukevich
dpasiukevich reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@dpasiukevich dpasiukevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls squash the commits? And then we'd merge the PR.

Thanks!

images/dnsmasq/validate_dynamic_deps.py Show resolved Hide resolved
@dpasiukevich
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dpasiukevich, wewark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fe41fca into kubernetes:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpasiukevich dpasiukevich dpasiukevich left review comments

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@dpasiukevich dpasiukevich

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image CVEs reported for version 1.22.17
3 participants
@wewark @k8s-ci-robot @dpasiukevich