Upgrade to CoreDNS 1.6.4 in node-cache. #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
Ran command : "dep ensure -v"
|
Upstream skydns has been updated. Verified that the new node-local-dns pods are cleaning up rules upon exit. |
k8s-ci-robot
removed
the
do-not-merge/hold
prameshj
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
new image is at k8s.gcr.io/k8s-dns-node-cache:1.15.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #306
This PR uses a fork of skydns - https://github.com/pasientskyhosting/skydns with all the dependencies fixed.
Thanks @chad-jones, I used most of your changes from #325, but the one change i did make is moving all constraints to Gopkg.toml, so there are no manual changes in Gopkg.lock
Verified that node-local-dns pods cleanup on exit.
Marking this PR on hold till we figure out if we can fix the original repo - skynetservices/skydns#350 or create another fork.
/hold