Skip to content

node-local-dns should support graceful shutdown with the ready plugin #642

Closed as not planned
@jsws

Description

@jsws

We are using node-local-dns with a CiliumLocal Redirect Policy as described here so we need node-local-dns to be able to become Not Ready once it receives a SIGTERM so time is given for the Endpoint to stop receiving traffic and for requests to be directed to kube-dns instead, before the pod is fully terminated. This will allow graceful rollouts of the node-local-dns daemonset.

In #485 it was requested the ready plugin be added to node-local-dns but it was closed on the basis it wouldn't serve any purpose as it would behave the same way as the health plugin. However I believe that's not the case and the ready plugin would allow node-local-dns to gracefully shutdown, since once it receives a SIGTERM the /ready endpoint would start returning 503 which can be used in a Readiness Probe on the pod to determine the pod is shutting down and give time for the Endpoint to be removed when used with the health plugins lameduck setting.
So I am again requesting the ready plugin be added to the plugins list here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions