Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services detail page now shows the ingressess related to it #6658

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

marcosdiez
Copy link
Contributor

@marcosdiez marcosdiez commented Dec 11, 2021

image

requires #6664

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2021
@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #6658 (913b034) into master (31ccdcb) will increase coverage by 0.19%.
The diff coverage is 0.00%.

❗ Current head 913b034 differs from pull request most recent head 15a4804. Consider uploading reports for the commit 15a4804 to get more accurate results

@@            Coverage Diff             @@
##           master    #6658      +/-   ##
==========================================
+ Coverage   41.85%   42.05%   +0.19%     
==========================================
  Files          44       44              
  Lines        1240     1227      -13     
  Branches      179      161      -18     
==========================================
- Hits          519      516       -3     
- Misses        682      711      +29     
+ Partials       39        0      -39     

@marcosdiez
Copy link
Contributor Author

All changes made. Thank you for the code review, @floreks !

@floreks
Copy link
Member

floreks commented Dec 16, 2021

I guess we'll have to wait first for the API version migration PR.

@marcosdiez
Copy link
Contributor Author

It's here: #6664 @floreks

@floreks
Copy link
Member

floreks commented Dec 16, 2021

@marcosdiez check my comment there 🙂

@floreks
Copy link
Member

floreks commented Jan 27, 2022

If you would just fix the static check issue we can merge this.

@marcosdiez marcosdiez force-pushed the ingress_of_services2 branch from 913b034 to 0a4e547 Compare January 31, 2022 09:20
@marcosdiez marcosdiez force-pushed the ingress_of_services2 branch from 0a4e547 to 15a4804 Compare January 31, 2022 09:41
@floreks
Copy link
Member

floreks commented Jan 31, 2022

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, marcosdiez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2d4c06b into kubernetes:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants