-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Services detail page now shows the ingressess related to it #6658
Services detail page now shows the ingressess related to it #6658
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6658 +/- ##
==========================================
+ Coverage 41.85% 42.05% +0.19%
==========================================
Files 44 44
Lines 1240 1227 -13
Branches 179 161 -18
==========================================
- Hits 519 516 -3
- Misses 682 711 +29
+ Partials 39 0 -39 |
5d0553c
to
913b034
Compare
All changes made. Thank you for the code review, @floreks ! |
I guess we'll have to wait first for the API version migration PR. |
@marcosdiez check my comment there 🙂 |
If you would just fix the static check issue we can merge this. |
913b034
to
0a4e547
Compare
0a4e547
to
15a4804
Compare
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, marcosdiez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
requires #6664