Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Restart action to Deployment details page #6644

Merged

Conversation

trentcain
Copy link
Contributor

@trentcain trentcain commented Dec 1, 2021

Fixes: #6639

Backend Changes -

  1. Added Restartable to TypeMeta. This is set to true for Deployment resources (similar to Scalable).

Frontend Changes -

  1. Added new restart detail action component (ActionbarDetailRestartComponent). The component contains a button with the refresh mat icon, clicking the button shows the restart dialog.
  2. Added the Restart action component to the Deployment action bar (ScaleDefaultActionbar). The action is only visible if typeMeta.restartable is true.
    Note for reviewer: I wasn't sure if this action bar should be renamed to something like ScaleRestartDefaultActionbar. Please let me know if this is required, or if this new restart detail action component belongs in a different component.
  3. Updated the existing list menu component to use typeMeta.restartable to determine if restart should be enabled in the menu.

Screenshot of new component:
Screenshot 2021-12-01 183854

Video of new component:

deployment.details.restart.mp4

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 1, 2021

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @trentcain!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 1, 2021
@maciaszczykm
Copy link
Member

/lgtm

Looks solid.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #6644 (0f59021) into master (24ac6ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6644   +/-   ##
=======================================
  Coverage   42.08%   42.08%           
=======================================
  Files          44       44           
  Lines        1226     1226           
  Branches      177      161   -16     
=======================================
  Hits          516      516           
- Misses        672      710   +38     
+ Partials       38        0   -38     

Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very minor nit pick 🙂

This is a really good idea to move this part and control it on the backend side. Code also looks good. Thanks!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2021
@trentcain
Copy link
Contributor Author

trentcain commented Dec 1, 2021

Tooltip updated. Thanks @maciaszczykm @floreks

@trentcain trentcain requested a review from floreks December 1, 2021 18:57
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit c28d562 into kubernetes:master Dec 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm, trentcain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Restart action to Deployment details page
4 participants