-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Restart action to Deployment details page #6644
Add Restart action to Deployment details page #6644
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @trentcain! |
/lgtm Looks solid. |
Codecov Report
@@ Coverage Diff @@
## master #6644 +/- ##
=======================================
Coverage 42.08% 42.08%
=======================================
Files 44 44
Lines 1226 1226
Branches 177 161 -16
=======================================
Hits 516 516
- Misses 672 710 +38
+ Partials 38 0 -38 |
src/app/frontend/common/components/actionbar/detailactions/restart/template.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very minor nit pick 🙂
This is a really good idea to move this part and control it on the backend side. Code also looks good. Thanks!
Tooltip updated. Thanks @maciaszczykm @floreks |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm, trentcain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #6639
Backend Changes -
Frontend Changes -
Note for reviewer: I wasn't sure if this action bar should be renamed to something like ScaleRestartDefaultActionbar. Please let me know if this is required, or if this new restart detail action component belongs in a different component.
Screenshot of new component:
Video of new component:
deployment.details.restart.mp4