Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosts are now shown in the ingress list #5800

Merged
merged 6 commits into from
Feb 18, 2021
Merged

Hosts are now shown in the ingress list #5800

merged 6 commits into from
Feb 18, 2021

Conversation

marcosdiez
Copy link
Contributor

@marcosdiez marcosdiez commented Feb 10, 2021 •
edited
Loading

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/de Updates or issues for German translations. labels Feb 10, 2021
@k8s-ci-robot k8s-ci-robot added language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Feb 10, 2021
@marcosdiez marcosdiez force-pushed the hosts_in_ingress_list branch from f893b6c to 550d4ca Compare February 10, 2021 14:43
@codecov
Copy link

codecov bot commented Feb 10, 2021 •
edited
Loading

Codecov Report

Merging #5800 (9119e36) into master (42a02a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5800   +/-   ##
=======================================
  Coverage   43.82%   43.82%           
=======================================
  Files         215      215           
  Lines        9167     9167           
  Branches      112      112           
=======================================
  Hits         4017     4017           
  Misses       4884     4884           
  Partials      266      266

@marcosdiez marcosdiez force-pushed the hosts_in_ingress_list branch from 550d4ca to 76a0fc0 Compare February 10, 2021 14:54
@marcosdiez marcosdiez changed the title Hosts are now shown in ingress the list Hosts are now shown in the ingress list Feb 10, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2021
@floreks
Copy link
Member

floreks commented Feb 18, 2021

/lgtm

@floreks floreks added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, marcosdiez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f86b89e into kubernetes:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks floreks left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@helight helight Awaiting requested review from helight

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcosdiez @floreks @k8s-ci-robot