Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closing sidemenu issue #5703

Merged

Conversation

theSinner
Copy link
Contributor

Hi

I have an issue with closing the side menu. When I close the side menu, the side menu content went away, but it's space stays.
I think the side menu component code is changed and now the hidden class is assigned to the wrong class.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2020
@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #5703 (c03143b) into master (20baa19) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5703      +/-   ##
==========================================
+ Coverage   44.36%   44.37%   +0.01%     
==========================================
  Files         214      214              
  Lines        9124     9124              
  Branches      113      113              
==========================================
+ Hits         4048     4049       +1     
  Misses       4801     4801              
+ Partials      275      274       -1     
Impacted Files Coverage Δ
src/app/frontend/login/component.ts 76.74% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20baa19...c03143b. Read the comment docs.

@maciaszczykm
Copy link
Member

Good spot. I can confirm that this is a problem on current master. Let me check your solution.

@maciaszczykm
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, theSinner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6c50d0f into kubernetes:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants