Use perl instead of sed to fix build error in macos. #5700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
In my previous PR for adding change language option, @floreks added some lines to
aio/scripts/build.sh
to prevent caching after changing language usingsed
command which makes build failed in macOS, because in macOSsed
command is a little bit different from Linux.I changed
sed
withperl
which does the same thing and the dashboard builds successfully in macOS and I think it works in Linux, too.