Build and push HEAD image on every build on master #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename canary to head for images that we build. This name conveys better what we actually do.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Current coverage is 93.76% (diff: 100%)@@ master #1377 diff @@
==========================================
Files 351 351
Lines 3081 3081
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2889 2889
Misses 192 192
Partials 0 0
|
|
@googlebot I'm ok with these commits being contributed to Google. |
floreks
requested changes
Oct 27, 2016
| # Cache downloaded Node.JS modules & Bower frontend dependencies for faster builds. | ||
| cache: | ||
| directories: | ||
| - node_modules | ||
| - bower_components | ||
| - .tools | ||
| - "$HOME/google-cloud-sdk/" |
There was a problem hiding this comment.
Not needed if we are not pushing to gcr also.
3 tasks
|
Done. PTAL |
floreks
approved these changes
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename canary to head for images that we build. This name conveys
better what we actually do.
This bases on @floreks work that he did on this topic. With a couple of alterations from me.