Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Official CVE Feed alpha #330

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Implementing Official CVE Feed alpha #330

merged 1 commit into from
Sep 7, 2022

Conversation

PushkarJ
Copy link
Member

@PushkarJ PushkarJ commented Aug 23, 2022 •
edited
Loading

  • Supporting blog to the announcement of the CVE feed
  • Covers implementation details, design considerations
  • Links to original blog

Preview: https://deploy-preview-330--kubernetes-contributor.netlify.app/blog/2022/09/12/k8s-cve-feed-alpha/
/sig security docs
/area security

related to kubernetes/website#35608 (Need both to be merged together) and kubernetes/enhancements#3203
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/security Categorizes an issue or PR as relevant to SIG Security. labels Aug 23, 2022
@k8s-ci-robot
Copy link
Contributor

@PushkarJ: The label(s) area/security cannot be applied, because the repository doesn't have them.

In response to this:

  • Supporting blog to the announcement of the CVE feed
  • Covers implementation details, design considerations
  • Links to original blog

/sig security docs
/area security

related to kubernetes/website#35608 (Need both to be merged together)
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2022
@k8s-ci-robot k8s-ci-robot requested review from jberkus and sftim August 23, 2022 18:46
@PushkarJ PushkarJ mentioned this pull request Aug 23, 2022
Merged
@PushkarJ PushkarJ force-pushed the docs-kep-3203-blog branch from 76b9b15 to 5ab302f Compare August 23, 2022 18:54
@PushkarJ PushkarJ mentioned this pull request Aug 23, 2022
Open
14 tasks
@PushkarJ PushkarJ changed the title [Feature Contributor Blog] K8s CVE Feed Implementing Official CVE Feed alpha Aug 23, 2022
@jberkus
Copy link
Contributor

jberkus commented Aug 24, 2022

Pushkar,

I've created this hackmd file because I wanted to rewrite parts of your blog post for clearer language, and that's easier than giving you a bunch of individual edits: https://hackmd.io/-5mXZZQWQyaTbU45O6AHhQ

@jberkus
Copy link
Contributor

jberkus commented Aug 24, 2022

Done editing the Hackmd file. Please review it; I think it improves some of the text around describing your implementation. Particularly, check how I converted passive to active voice in a lot of sentences.

sftim
sftim reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think we could merge this as-is.

Some feedback / tweaks, if you want them.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2022
@sftim
Copy link
Contributor

sftim commented Aug 24, 2022

/hold

due to #281

@PushkarJ
Copy link
Member Author

@jberkus can you please grant me access to hackmd link you shared?

@jberkus
Copy link
Contributor

jberkus commented Aug 24, 2022

Pushkar: it should be public. What are you seeing when you try to access it?

@jberkus
Copy link
Contributor

jberkus commented Aug 24, 2022

Aha, never mind, found the problem.

Use the view link if you don't have a hackmd account: https://hackmd.io/-5mXZZQWQyaTbU45O6AHhQ?view

@PushkarJ PushkarJ force-pushed the docs-kep-3203-blog branch from 5ab302f to 62f2679 Compare August 24, 2022 22:49
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 24, 2022
@PushkarJ PushkarJ force-pushed the docs-kep-3203-blog branch from 62f2679 to 99d190e Compare August 24, 2022 22:50
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 24, 2022
@PushkarJ
[Feature Contributor Blog] K8s CVE Feed
8dc00d8 
- Supporting blog to the announcement of the CVE feed
- Covers implementation details, design considerations
- Links to original blog

Updates based on PR feedback by `jberkus`
@PushkarJ PushkarJ force-pushed the docs-kep-3203-blog branch from 99d190e to 8dc00d8 Compare August 24, 2022 22:51
@PushkarJ
Copy link
Member Author

Thanks @jberkus and @sftim for the wonderful input via hackmd. I have updated the PR with the suggested changes!

@jberkus
Copy link
Contributor

jberkus commented Aug 25, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, PushkarJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@sftim sftim mentioned this pull request Aug 25, 2022
Merged
@imnmo
Copy link
Contributor

imnmo commented Aug 26, 2022

/hold

due to #281

@sftim could you please check this PR: #331 fixing the issue for future blog posts with PublishDate variable

@sftim
Copy link
Contributor

sftim commented Sep 7, 2022

Given that this will merge into main which already has the fix from #331

/hold cancel

🤞

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2ea958b into kubernetes:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jberkus jberkus Awaiting requested review from jberkus

Assignees

@jberkus jberkus

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/security Categorizes an issue or PR as relevant to SIG Security. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Contribex Comms Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PushkarJ @k8s-ci-robot @jberkus @sftim @imnmo