Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mengjiao-liu' email and company information #8245

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Update mengjiao-liu' email and company information #8245

merged 1 commit into from
Jan 14, 2025

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Jan 13, 2025 •
edited
Loading

The previous email address and company information are unavailable.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2025
@mengjiao-liu
Copy link
Member Author

/retest

@mengjiao-liu mengjiao-liu changed the title Update mengjiao-liu' email to sigs.yaml Update mengjiao-liu' email and company information Jan 13, 2025
@mengjiao-liu
Copy link
Member Author

The error message is as follows. Would you happen to know if I made any mistake? @BenTheElder

�[0;31mFAILED   verify-generated-docs.sh	46s
Verifying verify-spelling.sh
SUCCESS  verify-spelling.sh	3s
Verifying verify-steering-election.sh
SUCCESS  verify-steering-election.sh	1s
========================
�[0;31mFAILED TESTS
========================
�[0;31mhack/../hack/verify-generated-docs.sh
make: *** [Makefile:17: verify] Error 1

@palnabarun
Copy link
Member

@mengjiao-liu You would need to update the info in sigs.yaml and then run make.

@mengjiao-liu
Copy link
Member Author

@mengjiao-liu You would need to update the info in sigs.yaml and then run make.

Thanks! I ran the make command, re-pushed the commit, and the test passed.

pacoxu
pacoxu approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengjiao-liu, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3fe6c15 into kubernetes:master Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengjiao-liu @palnabarun @k8s-ci-robot @pacoxu