Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed the marketing-team subdirectory name to contributor-comms #6715

Merged
merged 3 commits into from
Sep 30, 2022
Merged

changed the marketing-team subdirectory name to contributor-comms #6715

merged 3 commits into from
Sep 30, 2022

Conversation

harshitasao
Copy link
Contributor

Which issue(s) this PR fixes:

Fixes: Part of #6641

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2022
@harshitasao harshitasao changed the title changing the marketing-team subdirectory name to contributor-comms changed the marketing-team subdirectory name to contributor-comms Jun 21, 2022
@harshitasao harshitasao mentioned this pull request Sep 9, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Sep 12, 2022
@chris-short
Copy link
Contributor

@mrbobbytables I think this is good to go.

@kaslin
Copy link
Contributor

kaslin commented Sep 23, 2022

@tpepper could you take a look at this or suggest someone else to review it?

@mrbobbytables
Copy link
Member

/label tide/merge-method-squash
/approve
/hold
For the actual dir change

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Sep 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshitasao, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@kaslin
Copy link
Contributor

kaslin commented Sep 30, 2022

Other PRs for this change are already in, waiting on this one. Unholding.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
@kaslin
Copy link
Contributor

kaslin commented Sep 30, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit b3fc4bf into kubernetes:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@kaslin kaslin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshitasao @chris-short @kaslin @mrbobbytables @k8s-ci-robot