Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update owners for ContribEx #6526

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Update owners for ContribEx #6526

merged 1 commit into from
Jun 8, 2022

Conversation

alisondy
Copy link
Contributor

@alisondy alisondy commented Mar 7, 2022

/hold for review
/assign @mrbobbytables @cblecker @nikhita

@mrbobbytables
Update owners for ContribEx
d6f5c59 
Co-authored-by: Bob Killen <bobkillen@google.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2022
@k8s-ci-robot k8s-ci-robot added area/community-management area/contributor-comms Issues or PRs related to the upstream marketing team labels Mar 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alisondy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/contributor-guide Issues or PRs related to the contributor guide area/devstats Issues or PRs related to the devstats subproject area/mentorship-planning Relating to strategy, planning,& executing of mentoring programs. NOT specific mentoring opportunty. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Mar 7, 2022
alisondy
alisondy commented Mar 7, 2022
View reviewed changes
Copy link
Contributor Author

@alisondy alisondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pinged all the folks who have been removed, or changed status in the review.

We will go forward with this in two weeks, and if there are any issues, we can restore back.

OWNERS
- committee-steering
emeritus_approvers:
- castrojo
- calebamiles
- grodrigues3
- spiffxp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spiffxp , Would you like to remain as an emeritus approver in the root owners file?

communication/OWNERS
- parispittman
- sig-contributor-experience-leads
emeritus_approvers:
- castrojo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@castrojo , Would you like to remain as an emeritus approver in the communication owners file?

communication/marketing-team/OWNERS
- Pensu
- rajula96reddy
- kaslin
emeritus_approvers:
- mbbroberg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mbbroberg Would you like to remain as an emeritus approver in the marketing team owners file?

contributors/guide/OWNERS
Comment on lines +7 to 8
- castrojo
- guineveresaenger
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@castrojo , @guineveresaenger

Would you like to remain as emeritus approvers in the contributor guide owners file?

contributors/guide/OWNERS
Comment on lines -6 to -7
- idvoretskyi
- tpepper
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idvoretskyi , @tpepper

Would you like to remain as reviewers in the contributor guide owners file?

events/OWNERS
Comment on lines -4 to -5
- parispittman
- tpepper
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpepper

Would you like to remain as a reviewer in the events owners file?

events/OWNERS
approvers:
- parispittman
- mrbobbytables
- guineveresaenger
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guineveresaenger

Would you like to remain as an approver in the events owners file?

sig-contributor-experience/devstats/OWNERS
emeritus_approvers:
- lukaszgryglicki
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukaszgryglicki

Would you like to remain as an emeritus approver in the devstats owners file?

@jdumars
Copy link
Member

jdumars commented May 4, 2022

Adding my LGTM so we can merge when the folks involved have resolved their roles moving forward. Thank you for te care that has gone into this process.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2022
@jdumars
Copy link
Member

jdumars commented Jun 8, 2022

Hey folks, just checking in on this since it has been a while. Any blockers preventing this from approval?

@mrbobbytables
Copy link
Member

I don't think so, there haven't been acks and we can always undo it in the future.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit a5dc6ee into kubernetes:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

@jdumars jdumars Awaiting requested review from jdumars

Assignees

@jdumars jdumars

@cblecker cblecker

@mrbobbytables mrbobbytables

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/contributor-comms Issues or PRs related to the upstream marketing team area/contributor-guide Issues or PRs related to the contributor guide area/devstats Issues or PRs related to the devstats subproject area/mentorship-planning Relating to strategy, planning,& executing of mentoring programs. NOT specific mentoring opportunty. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alisondy @k8s-ci-robot @jdumars @mrbobbytables @cblecker @nikhita