Skip to content

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Oct 21, 2019

The private steering slack channel is also called steering-committee, we should probably rename that to steering-private first.

/hold
/cc @kubernetes/steering-committee

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Oct 21, 2019
@nikhita
Copy link
Member Author

nikhita commented Oct 22, 2019

The channel has been renamed to steering-private now. 👍

@parispittman
Copy link
Contributor

/lgtm !

@dims
Copy link
Member

dims commented Oct 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2019
@mrbobbytables
Copy link
Member

/lgtm
from current slack admin 👍

@nikhita
Copy link
Member Author

nikhita commented Oct 22, 2019

/hold cancel

🎉

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9c204cc into kubernetes:master Oct 22, 2019
@nikhita nikhita deleted the steering-slack branch October 22, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants