Skip to content

Adds definitions for release stages #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2019
Merged

Adds definitions for release stages #4162

merged 1 commit into from
Oct 10, 2019

Conversation

guineveresaenger
Copy link
Contributor

This PR sends definitions and links to the kuberentes release phases.

Part of kubernetes/sig-release#319.

Links may not work until kubernetes/sig-release#827 is merged.

/sig release
/sig contributor-experience
/area contributor-guide
/area release-team
/assign @tpepper

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. area/contributor-guide Issues or PRs related to the contributor guide area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2019
@k8s-ci-robot k8s-ci-robot added the area/developer-guide Issues or PRs related to the developer guide label Oct 10, 2019
justaugustus
justaugustus suggested changes Oct 10, 2019
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, @guineveresaenger!

@guineveresaenger
Copy link
Contributor Author

thank you for catching those, @justaugustus! would you like me to squash?

@justaugustus
Copy link
Member

@guineveresaenger -- yes please! :)

@guineveresaenger
Copy link
Contributor Author

done! 😄

@justaugustus
Copy link
Member

Thanks, Guin!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guineveresaenger, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6cae345 into kubernetes:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpepper tpepper Awaiting requested review from tpepper

1 more reviewer

@justaugustus justaugustus justaugustus requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@justaugustus justaugustus

@tpepper tpepper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide area/developer-guide Issues or PRs related to the developer guide area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guineveresaenger @justaugustus @k8s-ci-robot @tpepper