Skip to content

Update steering committee membership in sigs.yaml #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

Update steering committee membership in sigs.yaml #4145

merged 1 commit into from
Oct 4, 2019

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Oct 4, 2019

@cblecker cblecker mentioned this pull request Oct 4, 2019
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. committee/steering Denotes an issue or PR intended to be handled by the steering committee. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2019
@dims
Copy link
Member

dims commented Oct 4, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ac20029 into kubernetes:master Oct 4, 2019
@cblecker cblecker deleted the steering branch October 4, 2019 17:46
timothysc
timothysc reviewed Oct 4, 2019
View reviewed changes
committee-steering/README.md
@@ -18,16 +18,11 @@ The [charter](https://git.k8s.io/steering/charter.md) defines the scope and gove

## Members

* Brian Grant (**[@bgrant0607](https://github.com/bgrant0607)**), Google
* Brendan Burns (**[@brendandburns](https://github.com/brendandburns)**), Microsoft
* Christoph Blecker (**[@cblecker](https://github.com/cblecker)**), Red Hat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think it's worth calling out Emeritus members as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We hadn't previously done this in sigs.yaml for steering before (Tim and Quinton aren't there), but had in git.k8s.io/steering/README.md. Happy to add them here too if we'd like

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme is sufficient, I've long since lost track of all the redundant places we've scrawled things down...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

@nikhita nikhita Awaiting requested review from nikhita

@parispittman parispittman Awaiting requested review from parispittman

@spiffxp spiffxp Awaiting requested review from spiffxp

1 more reviewer

@timothysc timothysc timothysc left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cblecker @dims @k8s-ci-robot @timothysc