Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about updating copyright for donated repos #3427

Closed
wants to merge 1 commit into from

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Mar 14, 2019

Ref: https://groups.google.com/d/topic/kubernetes-sig-architecture/TjHLgJcDF-I/discussion

fyi @kubernetes/owners @caniszczyk

/cc @dims @justaugustus @swinslow
licensing subproject members

/assign @spiffxp
github-management owner

/assign @swinslow
/hold
Want to make sure that we get lgtm by @swinslow because this is legalese

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikhita
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: spiffxp

If they are not already assigned, you can assign the PR to them by writing /assign @spiffxp in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

I feel like the copyright update/transfer should happen pre-migration, as the specific project would be out of compliance between the time it migrated in and the time it takes for someone to PR the copyright update.

Then again, I'm not a lawyer, so I'll leave the final word to @swinslow. :)

@swinslow
Copy link
Contributor

Hi @nikhita @dims @justaugustus — appreciate all the suggestions here =) All good comments. I’m going to add a few edits to clarify the differences between updating copyright notices vs. the copyrights themselves (which remain owned by the original contributors). Will try to add in the next day or so.

@nikhita
Copy link
Member Author

nikhita commented Mar 15, 2019

Fyi @ahmetb
(ref kubernetes/org#599)

@nikhita
Copy link
Member Author

nikhita commented Mar 23, 2019

I’m going to add a few edits to clarify the differences between updating copyright notices vs. the copyrights themselves (which remain owned by the original contributors).

Do you think we could also add details about when the copyright year should be updated - in general, not just for migration? Maybe we could collate all copyright related information, add it to the sig-release repo and link it here?

cc @neolit123

@nikhita
Copy link
Member Author

nikhita commented Mar 28, 2019

Closing in favour of #3511

/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closed this PR.

In response to this:

Closing in favour of #3511

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahmetb added a commit to ahmetb/krew that referenced this pull request Apr 1, 2019
Reference: kubernetes/community#3427

Updating the source code copyright per the kubernetes/org#599
as someone from the Google organization which has donated the krew code.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
k8s-ci-robot pushed a commit to kubernetes-sigs/krew that referenced this pull request Apr 3, 2019
Reference: kubernetes/community#3427

Updating the source code copyright per the kubernetes/org#599
as someone from the Google organization which has donated the krew code.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants