github-management: clarify sponsorship criteria #3256
Conversation
An approver/reviewer in @kubernetes, may sponsor someone for the kubernetes org or any of the related organizations (kubernetes-sigs, kubernetes-csi etc); as long as it's a project they're involved with. However, this does not work the other way around. A sponsor that is only an approver/reviewer in kubernetes-sigs cannot sponsor someone for membership in the kubernetes org. They are scoped just to the org they're associated with.
k8s-ci-robot
added
the
sig/contributor-experience
k8s-ci-robot
added
cncf-cla: yes
| - Sponsors must be reviewers or approvers in at least 1 OWNERS file (in any repo in the Kubernetes GitHub | ||
| organization) | ||
| - Sponsors must be reviewers or approvers in at least 1 OWNERS file either in any repo in the [Kubernetes org], | ||
| or the org they are sponsoring for. |
There was a problem hiding this comment.
I like the addition, but we may want to expand on it with a small example along the lines of:
"Example: A sponsor who is only an reviewer or approver within a Kubernetes-sigs project, may only sponsor for the Kubernetes-sigs org"
It's sort of expanded upon further down in the Kubernetes ecosystem part:
"However, if you are a member of any of the related Kubernetes GitHub organizations but not of the Kubernetes org, you will need explicit sponsorship for your membership request."
but I think that part is being skimmed over :x
|
/lgtm Holding for other review comments, but I'm good with this as is. |
k8s-ci-robot
added
lgtm
|
/lgtm LGTM to as is. I'll let @mrbobbytables pull the hold. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, justaugustus, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @nikhita :) |
k8s-ci-robot
removed
the
do-not-merge/hold
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I guess that is a sarcastic "yay" pony =p |
An approver/reviewer in @kubernetes, may sponsor someone for the @kubernetes org or any of the related organizations (@kubernetes-sigs, @kubernetes-csi etc); as long as it's a project they're involved with.
However, this does not work the other way around. A sponsor that is only an approver/reviewer in @kubernetes-sigs cannot sponsor someone for membership in the @kubernetes org. They are scoped just to the org they're associated with.
Hopefully this reduces some of the back and forth (example kubernetes/org#470 (comment)) for @mrbobbytables and @justaugustus. 😄
/sig contributor-experience
/area github-management
/cc @cblecker @mrbobbytables @spiffxp @justaugustus
/assign @cblecker