Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a moderator template #3253

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Add a moderator template #3253

merged 1 commit into from
Feb 26, 2019

Conversation

castrojo
Copy link
Member

This adds a moderator template so that moderators can apply via the community repo.

Signed-off-by: Jorge O. Castro <jorgec@vmware.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@castrojo
Copy link
Member Author

/sig contributor experience
/assign cblecker

@nikhita
Copy link
Member

nikhita commented Feb 13, 2019

@castrojo Can we add an OWNERS file for .github so that we can automatically apply the sig/contributor-experience for all PRs that target that directory?

@castrojo
Copy link
Member Author

Sure, is it possible to do a team ownership or should I just clone the owners file from the root of this repo?

@nikhita
Copy link
Member

nikhita commented Feb 14, 2019

Sure, is it possible to do a team ownership or should I just clone the owners file from the root of this repo?

If by team ownership, you mean GitHub team ownership - no, that's not possible today.

Cloning the OWNERS file from the root sgtm...but if that's the case, we don't really need to add it because without it, the approval needs to come from root OWNERS anyway. ¯\_(ツ)_/¯

I'm fine with not adding an explicit OWNERS file too in that case. :)

@castrojo
Copy link
Member Author

Yeah I think I'll skip the OWNERS file if it's just us again. Thanks!

@cblecker
Copy link
Member

/hold

Thanks for this Jorge! I'm going to copy over some generic templates first, and then we can merge this in.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2019
@nikhita
Copy link
Member

nikhita commented Feb 26, 2019

Looks like this is good to go since #3285 merged.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo, jdumars

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jdumars
Copy link
Member

jdumars commented Feb 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@jdumars
Copy link
Member

jdumars commented Feb 26, 2019

We need moderators yesterday, so someone please unhold this besides me :)

@cblecker
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2ebdefc into kubernetes:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants