Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add community resources #2905

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Add community resources #2905

merged 2 commits into from
Nov 6, 2018

Conversation

pbnj
Copy link
Contributor

@pbnj pbnj commented Nov 6, 2018

/sig contributor-experience
/assign @castrojo

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/community-management needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2018
@pbnj
Copy link
Contributor Author

pbnj commented Nov 6, 2018

This is a pull request per a conversation with @castrojo here

@jdumars
Copy link
Member

jdumars commented Nov 6, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2018
@jdumars
Copy link
Member

jdumars commented Nov 6, 2018

General comment: thanks for assembling the list!

@jdumars
Copy link
Member

jdumars commented Nov 6, 2018

/lgtm
nice work!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2018
idvoretskyi
idvoretskyi approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idvoretskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6bdb2ff into kubernetes:master Nov 6, 2018
@pbnj pbnj deleted the feat/add-resources branch November 6, 2018 15:05
@pbnj pbnj mentioned this pull request Feb 19, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdumars jdumars jdumars left review comments

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@jdumars jdumars

@castrojo castrojo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbnj @jdumars @k8s-ci-robot @idvoretskyi @castrojo