Docs: Min Supported Version & Removal of In-Tree Config #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
andrewsykim
reviewed
Oct 9, 2019
andrewsykim
reviewed
Oct 9, 2019
|
LGTM, can we squash the commits and update the message to include removaal of in-tree configs? |
davidvonthenen
changed the title
Updates Remove duplicate line
davidvonthenen
force-pushed
the
docs/minsupport
branch
from
9eb491e to
5c783bf
Compare
|
@andrewsykim commits squashed and title updated. |
davidvonthenen
changed the title
davidvonthenen
changed the title
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Based on vCenter/ESXi compatibility testing, the CPI and CSI components will only support 6.7u3 or later (ie both vCenter and ESX hosts must be 6.7u3 or later). This prerequisite is due to the CSI requiring CNS support which first became available in 6.7u3. Since CPI and CSI are tightly coupled, CPI will also inherit that minimum version of vSphere.
This PR also attempts to clean up some documentation around the cloud-config. The previous version of the documentation covered both the in-tree vSphere Cloud Provider and external CPI/CSI component cloud-config which lead to some confusion. The cloud-config doc has been updated to only cover the external CPI/CSI components and includes updates to missing params from the config.
Which issue this PR fixes: #261 and #255
Special notes for your reviewer:
NA
Release note:
NA