Skip to content

Commit

Permalink
Merge pull request #1049 from XudongLiuHarold/clean-up-useless-build-…
Browse files Browse the repository at this point in the history
…push-target

clean up scripts to push image for vmware registry
  • Loading branch information
k8s-ci-robot authored May 30, 2024
2 parents 56eaa6a + d3c4561 commit b087162
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 335 deletions.
16 changes: 0 additions & 16 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -315,29 +315,13 @@ staticcheck:

vet:
hack/check-vet.sh
################################################################################
## BUILD IMAGES AND BINARIES ##
################################################################################
.PHONY: release
release: | $(DOCKER_SOCK)
hack/release.sh

################################################################################
## PUSH IMAGES AND BINARIES ##
################################################################################
.PHONY: release-push
release-push: | $(DOCKER_SOCK)
hack/release.sh -p

################################################################################
## CI IMAGE ##
################################################################################
build-ci-image:
$(MAKE) -C hack/images/ci build

push-ci-image:
$(MAKE) -C hack/images/ci push

print-ci-image:
@$(MAKE) --no-print-directory -C hack/images/ci print

Expand Down
54 changes: 0 additions & 54 deletions hack/ensure-kubectl.sh

This file was deleted.

5 changes: 0 additions & 5 deletions hack/images/ci/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ rebuild: MAKEFLAGS += --always-make
rebuild:
$(MAKE) build

.PHONY: push
push: $(IMAGE_D) login-to-image-registry
docker push $(IMAGE):$(VERSION)
docker push $(IMAGE):latest

.PHONY: ls-images
ls-images:
docker images --filter=reference=$(IMAGE):*
Expand Down
11 changes: 0 additions & 11 deletions hack/images/ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,17 +119,6 @@ $ docker run -it --rm \
make integration-test
```

## Deploy the CCM image

Pushing the images requires bind mounting a GCR key file into the container and setting the environment variable `GCR_KEY_FILE` to inform the deployment process the location of the key file:

```shell
$ docker run -it --rm --privileged \
-e "GCR_KEY_FILE=/keyfile.json" -v "$(pwd)/keyfile.json":/keyfile.json \
gcr.io/cloud-provider-vsphere/ci \
make push-images
```

## Execute the conformance tests

Running the e2e conformance suite not only requires DinD but also an environment variable file that provides the information required to turn up a Kubernetes cluster against which the e2e tests are executed. For example:
Expand Down
29 changes: 0 additions & 29 deletions hack/make/login-to-image-registry.mk

This file was deleted.

220 changes: 0 additions & 220 deletions hack/release.sh

This file was deleted.

0 comments on commit b087162

Please sign in to comment.