Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds integration test framework and initial tests for GCP cloud controller manager #762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Sep 16, 2024

  • Adds integration tests for GCP cloud-controller-manager
  • (within integration test directory):
$ go test -v ./...
...
--- PASS: Test_CloudControllerManagerGCP (12.28s)
PASS
...

NOTE: There is currently a goroutine leak caused by the NodeIPAMController loop

	found unexpected goroutines:
	[Goroutine 4414 in state chan receive, with k8s.io/apimachinery/pkg/watch.(*Broadcaster).loop on top of the stack:
	k8s.io/apimachinery/pkg/watch.(*Broadcaster).loop(0xc008df8500)
		/home/sean/go/pkg/mod/k8s.io/apimachinery@v0.31.0/pkg/watch/mux.go:268 +0x66
	created by k8s.io/apimachinery/pkg/watch.NewLongQueueBroadcaster in goroutine 4347
		/home/sean/go/pkg/mod/k8s.io/apimachinery@v0.31.0/pkg/watch/mux.go:93 +0x125
...

NOTE2: There is currently no BUILD file to run the test using bazel -- yet.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@seans3 seans3 changed the title Adds integration test framework and initial tests for GCP cloud controller manager [WIP] Adds integration test framework and initial tests for GCP cloud controller manager Sep 16, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 16, 2024
@seans3 seans3 force-pushed the ccm-integration-test branch from da53d8f to 4829077 Compare September 16, 2024 04:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seans3
Once this PR has been reviewed and has the lgtm label, please assign jprzychodzen for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seans3
Copy link
Contributor Author

seans3 commented Oct 4, 2024

/retest

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants