add mikedanese to owners #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikdanese needs to approve changes to gke-certificates-controller which will live in this repo. mikedanese is: * emeritus maintainer of gcp cloud provider. * owner of k8s.io/kubernetes/pkg/cloudprovider.
k8s-ci-robot
added
cncf-cla: yes
|
/approve /lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: calebamiles Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelmdresser
added a commit
to michaelmdresser/cloud-provider-gcp
that referenced
this pull request
Jun 18, 2020
In a fresh GCP project, kube-up.sh will fail on two runs before succeeding. This is because it copies two files to staging during its run. When the file kubernetes#1 is copied to the bucket, we hit this ACL-setting line which fails for weird bucket permission errors. The next run, kube-up discovers that file kubernetes#1 is already in the bucket and doesn't call copy-to-staging, proceeding instead to copying file kubernetes#2 to staging. The same error occurs. On the third run, both files are determined to be in the bucket and available and so the script proceeds without incident and completes a successful run. With this addition of || true, multiple runs are not necessary.
ialidzhikov
pushed a commit
to ialidzhikov/cloud-provider-gcp
that referenced
this pull request
Jul 27, 2020
Update k8s.io/legacy-cloud-providers to v0.18.3
nicknagi
added a commit
to nicknagi/cloud-provider-gcp
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mikdanese needs to approve changes to gke-certificates-controller which
will live in this repo.
mikedanese is: