Request to implement resource version behavior in fake clientset

[cofyc]

Global or per object incremental resource version.
It helps to test logic involving resource version and detect races.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[cofyc]

/close

[k8s-ci-robot]

@cofyc: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aholic]

hello
is there any better method to test data race?

[kopaygorodsky]

I also stumbled on the luck of this feature in the fake client. Did anything change during 2 years?

[wenqiq]

It`s unfortunately that the feature is not implemented. I recommend one method that maybe useful.

We can use fakeClient.AddReactor to mock the error.
For example:
https://github.com/kubernetes/kubernetes/pull/99398/files

https://github.com/antrea-io/antrea/pull/2444/files

[zeevmoney]

It`s unfortunately that the feature is not implemented. I recommend one method that maybe useful.

We can use fakeClient.AddReactor to mock the error. For example: https://github.com/kubernetes/kubernetes/pull/99398/files

https://github.com/antrea-io/antrea/pull/2444/files

Though this issue is closed, I found a simpler way to do what @wenqiq referenced here (thanks).
If you init a fake client without fake.NewSimpleClientset(), then creating fake resources using the API won't work, because this func creates a clientset with a reactor that creates objects:
cs.AddReactor("*", "*", testing.ObjectReaction(o))

So, my solution was:

1. Create fake client using fake.NewSimpleClientset().
2. Run some setupPods func (in my case I needed fake pods).
3. Use client.PrepandReactor to mock some failure after X calls:

Clientset.PrependReactor("update", "*", func(action k8stesting.Action) (handled bool, ret runtime.Object, err error) {
// ...
}

4. Run the code that's being tested.