Skip to content

Add context to "Watch failed" #1321

Open
@jsoref

Description

A number of systems (especially argocd) experience a log message of the form:

1 retrywatcher.go:130] "Watch failed" err="context canceled"

To Reproduce

Dunno

Expected behavior

Log messages should give enough context for someone reading them to understand what's going on, i.e. "I tried to do x and a watch failed".

victims

general search: https://github.com/search?q=%22Watch+failed%22+kubernetes+retrywatcher.go&type=issues

argoproj/argo-cd#14134 (comment)
okteto/okteto#3911 (comment)
aws/eks-anywhere#6535 (comment)
devopstales/devopstales.github.io#7 (comment)
kubernetes/kubernetes#118731 (comment)
open-cluster-management-io/ocm#186 (comment)

Metadata

Assignees

No one assigned

    Labels

    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions